swap out local definition of Fields for http::HeaderMap #19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
same authors, slightly different interfaces
…ttp crate and get rid of the aliases. this crate doesnt even expose trailers, when we do it can just be a method called trailers(&self) -> &HeaderMap, no big deal.
and propogate some errors out instead of unwrapping
sunfishcode
added a commit
to sunfishcode/wstd
that referenced
this pull request
Jan 2, 2025
Since as of bytecodealliance#19, wstd is using the http crate's types for `HeaderMap`, `Method`, and `Uri`, switch it to use the http crate's types for `Request`, `Response`, and `StatusCode` too. These types have a few more features, and this change makes wstd more interoperable with code that uses the http crate. This also helps with bytecodealliance#34, as the new `Request` and `Response` types here are independent of being incoming or outgoing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than put the work into a case-insensitive map for header names and values, lets just reuse the perfectly good one from the http crate. Closes #9
Swap out url::Url for http::uri::Uri as well.
And then, once again no real reason to maintain a local definition of Method, so lets re-export http::Method.
Finally, add
headers(&self) -> &HeaderMapandheaders_mut(&mut self) -> &mut HeaderMaptoRequest, just like the one onResponse. Closes #11